[PATCH] D54125: [LTO] Drop non-prevailing definitions for non-local linkage types

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM, just a few comments that need to be updated before submit. Thanks!



================
Comment at: lib/LTO/LTO.cpp:318
 
 // Resolve Weak and LinkOnce values in the \p Index.
 //
----------------
tejohnson wrote:
> Please update the comment.
This comment still needs a fix.


================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:503
 
 /// Resolve LinkOnce/Weak symbols. Record resolutions in the \p ResolvedODR map
 /// for caching, and in the \p Index for application during the ThinLTO
----------------
Update comment


================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:678
 
   // Resolve LinkOnce/Weak symbols.
   StringMap<std::map<GlobalValue::GUID, GlobalValue::LinkageTypes>> ResolvedODR;
----------------
Comment needs update.


Repository:
  rL LLVM

https://reviews.llvm.org/D54125