[PATCH] D43245: [LoopInterchange] Support reductions across inner and outer loop.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopInterchange.cpp:689
+          return false;
+      } else if (PHI.getNumIncomingValues() == 2) {
+        // Check if we have a PHI node in the outer loop that has a reduction
----------------
efriedma wrote:
> I think "PHI.getNumIncomingValues() == 2" must be true?  If it weren't true, it would imply the loop header had more than two predecessors (and I think you disallow that elsewhere).
Yep, I turned it into an assertion.


https://reviews.llvm.org/D43245