[PATCH] D54194: [llvm-rc] Support absolute filenames in manifests

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 8 01:10:30 PST 2018


mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/tools/llvm-rc/absolute.test:5
+
+; CHECK-NOT: Assertion `!path::is_absolute(FileName)' failed.
----------------
The negative check for assertion might be a bit overkill, as a failed assert would make the `llvm-rc` command itself fail (a plain `; RUN: llvm-rc %t.rc` to see that it can successfully compile that file would be enough), but I don't mind this either.


Repository:
  rL LLVM

https://reviews.llvm.org/D54194





More information about the llvm-commits mailing list