[PATCH] D54219: [AMDGPU] Extend promote alloca vectorization

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 12:34:15 PST 2018


arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/promote-alloca-vector-to-vector.ll:1-2
+; RUN: llc -march=amdgcn -mcpu=fiji -verify-machineinstrs < %s | FileCheck -check-prefixes=GCN,GFX8 %s
+; RUN: llc -march=amdgcn -mcpu=gfx900 -verify-machineinstrs < %s | FileCheck -check-prefixes=GCN,GFX9 %s
+
----------------
Should have opt run lines


================
Comment at: test/CodeGen/AMDGPU/promote-alloca-vector-to-vector.ll:34
+entry:
+  %alloca = alloca <4 x float>, align 16, addrspace(5)
+  %x = tail call i32 @llvm.amdgcn.workitem.id.x()
----------------
Could use some tests with half/i16


https://reviews.llvm.org/D54219





More information about the llvm-commits mailing list