[PATCH] D54096: [WebAssembly] Add support for the event section

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp:102
+    // weak.
+    WasmSym->setWeak(true); // TODO aheejin how to set odr?
+    WasmSym->setExternal(true);
----------------
dschuff wrote:
> I guess this answers my question above.
> We could have this symbol weakly defined in throwing/catching object files, and then strongly defined in libcxxabi? Or we could use a COMDAT?
Why would need a strong definition in libcxxabi?  For that matter there is no syntax for defining it in code so I'm not sure how we would do that (assembly I guess?)


Repository:
  rL LLVM

https://reviews.llvm.org/D54096