[PATCH] D53887: [HotColdSplitting] Outline more than once per function

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 13:00:06 PST 2018


vsk added a comment.

In https://reviews.llvm.org/D53887#1290584, @junbuml wrote:

> I guess it would be good to give some stress test on this pass to see if there is any hidden bug by relaxing conditions in unlikelyExecuted().  As we treat more blocks as cold without being limited on unlikelyExecuted(), we maybe able to expose hidden issues with it.


That's a great idea. I'll do that now with the test-suite + externals. FWIW, I also built all of iOS with this pass enabled, and the only compiler crash I found was https://bugs.llvm.org/show_bug.cgi?id=39564. I'm still investigating possible miscompiles.


https://reviews.llvm.org/D53887





More information about the llvm-commits mailing list