[PATCH] D54212: [PGO] early exit if all count values are zero

Rong Xu via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 10:02:13 PST 2018


On Wed, Nov 7, 2018 at 9:13 AM David Li via Phabricator <
reviews at reviews.llvm.org> wrote:

> davidxl added inline comments.
>
>
> ================
> Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1485
>        continue;
> +    if (AllZeros) {
> +      if (Func.getProgramMaxCount() != 0)
> ----------------
> Is function entry annotated ?
>
You are right. Entry should be annotated. I will update the patch.


>
>
> https://reviews.llvm.org/D54212
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181107/f141136f/attachment.html>


More information about the llvm-commits mailing list