[PATCH] D53710: [FileCheck] Warn if a prefix is only used in LABEL checks

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

I think what we've determined so far is that some uses of CHECK-LABEL simply misunderstand the LABEL suffix, which IMO is because the suffix is very poorly named.  Renaming it to something harder to misunderstand would be a lot of churn but ultimately benefit the project's tests.  The process of updating all tests with LABEL would necessarily find all the dodgy cases.  And with a better-understood FileCheck feature, ultimately I think there would be fewer cases of bad tests.
(It would also help if people responsibly made sure their tests failed when their patch was NOT applied, but we have no process for this.)

Renaming CHECK-LABEL to, say, CHECK-BOUND is way more work than you signed up for, but I think it's preferable than piling more options and warnings on top of the existing feature.  I'd support an RFC to do this and help with some of the mechanical work.


https://reviews.llvm.org/D53710