[PATCH] D54199: [CodeGen] Fix bugs in BranchFolderPass when debug labels are generated.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 08:11:11 PST 2018


aprantl added inline comments.


================
Comment at: lib/CodeGen/BranchFolding.cpp:300
 ///  Whether MI should be counted as an instruction when calculating common tail.
 static bool countsAsInstruction(const MachineInstr &MI) {
+  return !(MI.isDebugInstr() || MI.isCFIInstruction());
----------------
There is MachineInstr::isMetaInstruction(). Could you please remove this helper function and use that instead?


Repository:
  rL LLVM

https://reviews.llvm.org/D54199





More information about the llvm-commits mailing list