[PATCH] D48826: [AMDGPU] Add support for TFE/LWE in image intrinsics

David Stuttard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 06:24:45 PST 2018


dstuttard added a reviewer: sheredom.
dstuttard added a comment.

Added Neil as a reviewer as I've made some changes to some of his a16 tests. I'm pretty certain that the modifications are correct, but wanted to get feedback on that as well.

I think that we can get rid of adjustWriteMask altogether at some point, but it will require extra support in the instcombine for the image instructions to support TFE/LWE (it just gives up at the moment), but it is definitely wrong to have this code in 2 places. However, we can do that as a separate change - this one is getting quite large already!


Repository:
  rL LLVM

https://reviews.llvm.org/D48826





More information about the llvm-commits mailing list