[PATCH] D54207: [ELF] Make TrapInstr and Filler byte arrays. NFC.

James Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 06:20:34 PST 2018


jrtc27 created this revision.
jrtc27 added a reviewer: ruiu.
Herald added subscribers: llvm-commits, jsji, atanasyan, kbarton, arichardson, javed.absar, nemanjai, sdardis, emaste.
Herald added a reviewer: espindola.

The uint32_t type does not clearly convey that these fields are
interpreted in the target endianness. Converting them to byte arrays
should make this more obvious and less error-prone.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54207

Files:
  ELF/Arch/ARM.cpp
  ELF/Arch/Mips.cpp
  ELF/Arch/PPC64.cpp
  ELF/Arch/X86.cpp
  ELF/Arch/X86_64.cpp
  ELF/OutputSections.cpp
  ELF/OutputSections.h
  ELF/ScriptParser.cpp
  ELF/Target.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54207.172941.patch
Type: text/x-patch
Size: 8205 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181107/6a2052dd/attachment.bin>


More information about the llvm-commits mailing list