[PATCH] D54200: [PPC64] Use -0x80000000LL instead of std::numeric_limits<int32_t>::min()

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 04:04:16 PST 2018


jhenderson added a comment.

In https://reviews.llvm.org/D54200#1289971, @arichardson wrote:

> Is the problem here that we are missing a cast to int64_t?


Not sure if you're referring to the original problem, but I assume you are. The original issue was highlighting a bug in MSVC's C++11 compatibility, as the type of the (now replaced) integer literal should be a signed long long automatically (effectively an int64_t), but instead it became an unsigned int. Casting it to an int64_t explicitly would also have worked, I think.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54200





More information about the llvm-commits mailing list