[PATCH] D54200: [PPC64] Use -0x80000000LL instead of std::numeric_limits<int32_t>::min()

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 01:59:03 PST 2018


jhenderson added a comment.

I'm honestly not really convinced that -0x80000000LL is more readable. I think it's a matter of personal taste. I think numeric_limits<int32_t>::min() is more explicit about what it's aiming to achieve. That being said, I really don't care that much, so if somebody else gives a LGTM, I don't mind.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54200





More information about the llvm-commits mailing list