[PATCH] D54007: Use a data structure better suited for large sets in SimplificationTracker.

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added a comment.

In https://reviews.llvm.org/D54007#1289874, @bjope wrote:

> In https://reviews.llvm.org/D54007#1289855, @skatkov wrote:
>
> > Just a note, there is a specific usage of this data structure. 
> >  Phi nodes are inserted in the initial step without any removals and then only removals are used.
> >
> > So we should not see something like delete-insert.
> >  So while data structure really suffers from what Bjorn wrote but in this specific application of this data structure I do not expect any problems...
>
>
> Ok. Just worried that someone might find this set implementation nifty, trying to reuse it in some other part of the code or moving it to ADT, without considering this limitation regarding delete-insert.


Completely agreed!


Repository:
  rL LLVM

https://reviews.llvm.org/D54007