[PATCH] D53887: [HotColdSplitting] Outline more than once per function

[Vedant Kumar via Phabricator via llvm-commits]

vsk updated this revision to Diff 172867.
vsk retitled this revision from "[HotColdSplitting] [WIP] Outline more than once per function" to "[HotColdSplitting] Outline more than once per function".
vsk edited the summary of this revision.
vsk added a comment.

Removing the WIP label, as I'm confident in the results now.

- Fix an iterator invalidation bug in takeSingleEntrySubRegion.
- I've addressed the immediate miscompile reported in llvm.org/PR39545, and plan on improving handling of eh.typeid.for in a follow-up.
- @junbuml has concerns about applying MinSize to functions which call exit. IMHO the right fix is to not treat noreturn calls as cold (also as a follow-up).


https://reviews.llvm.org/D53887

Files:
  llvm/lib/Transforms/IPO/HotColdSplitting.cpp
  llvm/test/Transforms/HotColdSplit/eh-pads.ll
  llvm/test/Transforms/HotColdSplit/mark-the-whole-func-cold.ll
  llvm/test/Transforms/HotColdSplit/outline-disjoint-diamonds.ll
  llvm/test/Transforms/HotColdSplit/outline-multiple-entry-region.ll
  llvm/test/Transforms/HotColdSplit/region-overlap.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53887.172867.patch
Type: text/x-patch
Size: 27585 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181106/adc56c18/attachment.bin>