[PATCH] D54154: [ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 6 15:15:41 PST 2018


ruiu added a comment.

Yeah, we could alternatively represent a trap instruction as an ArrayRef<uint8_t> which can vary in size, but that's somewhat minor point, and I believe always writing 4 bytes using memcpy is much faster than copying ArrayRef contents because the former can be highly optimized by a compiler that can inline memcpy function.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54154





More information about the llvm-commits mailing list