[PATCH] D54126: [WebAssembly] Renumber and LEB128-encode SIMD opcodes

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 6 15:02:02 PST 2018


aheejin added a comment.

This CL does not only do renumbering but also do some of refactoring by unifying classes into unaries and binaries. Ideally they can be splitted, but if we want to do them herer together maybe we can add that part of explanation to the CL/commit description.



================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:555
                            [(set (vec_t V128:$dst), (vec_t (vnot V128:$vec)))],
-                           "v128.not\t$dst, $vec", "v128.not", 63>;
-}
-
-defm "" : SIMDNot<v16i8>;
-defm "" : SIMDNot<v8i16>;
-defm "" : SIMDNot<v4i32>;
-defm "" : SIMDNot<v2i64>;
+                           "v128.not\t$dst, $vec", "v128.not", 79>;
 
----------------
Can we use `SIMDUnary` for this?


Repository:
  rL LLVM

https://reviews.llvm.org/D54126





More information about the llvm-commits mailing list