[PATCH] D53907: [DWARFv5] Read and dump multiple .debug_info sections

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFObject.h:37
+  virtual void
+  forEachInfoSections(function_ref<void(const DWARFSection &)> F) const {}
   virtual void
----------------
aprantl wrote:
> aprantl wrote:
> > A more common pattern in LLVM seems to be an debug_info_sections() accessor that returns an iterator range, such as in http://llvm.org/doxygen/classllvm_1_1object_1_1ObjectFile.html#a7f73649118e365a230be4870d824e7cf
> I don't feel very strongly about it, the iterator range just seems to be slightly more flexible as an interface.
I did it this way to match what was in place for .debug_types; I can take an action to follow up with an iterator range.  I'd rather not throw in an NFC refactor of .debug_types along with the functional part.


Repository:
  rL LLVM

https://reviews.llvm.org/D53907