[PATCH] D49362: [ThinLTO] Internalize read only globals

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 6 13:14:57 PST 2018


tejohnson added a comment.

In https://reviews.llvm.org/D49362#1289304, @evgeny777 wrote:

> > the call to propagateConstantsToRefs only on function summaries
>
> This will not work, because we need to drop read only attribute from GVs, referenced by initializer


Right, forgot about the fact that while the GlobalVar refs are never marked read only, the info still needs to be propagated. So might as well do that call on all summaries, since you already note in the function that for aliases it will be a no-op.


https://reviews.llvm.org/D49362





More information about the llvm-commits mailing list