[PATCH] D54173: Add MemOp into LDRcp to enable removing

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

(It's customary to mention the target name in the title for patches which only touch one target, e.g. "[ARM] Add MemOp into LDRcp to enable removing", to help people quickly sort through llvm-commits.)



================
Comment at: test/CodeGen/ARM/ldrcppic.ll:1
+; RUN: llc -relocation-model=pic -mcpu=cortex-a53 %s -filetype=obj -o - | llvm-nm - | FileCheck %s
+
----------------
Probably worth adding a comment to explain this RUN line, since it's a bit unusual.


================
Comment at: test/CodeGen/ARM/ldrcppic.ll:47
+
+attributes #0 = { "linker_input_section"=".data._ZN15UsecaseSelector25AllowedImplDefinedFormatsE^^chxusecaseutils.o^^54ac3d2348b46392" }
+attributes #1 = { noinline nounwind optnone sspstrong uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "linker_input_section"=".text._ZN15UsecaseSelector26IsAllowedImplDefinedFormatE15ChiBufferFormatj^^chxusecaseutils.o^^54ac3d2348b46392" "min-legal-vector-width"="0" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="cortex-a53" "target-features"="+armv8-a,+crc,+crypto,+dsp,+fp-armv8,+hwdiv,+hwdiv-arm,+neon,-d16,-dotprod,-fp-only-sp,-fp16fml,-ras,-thumb-mode" "unsafe-fp-math"="false" "use-soft-float"="false" }
----------------
Please clean up the testcase to get rid of unnecessary attributes/branches/etc.


Repository:
  rL LLVM

https://reviews.llvm.org/D54173