[PATCH] D49491: [RFC][VPlan, SLP] Add simple SLP analysis on top of VPlan.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added a comment.

What about non-vectorizable loads/stores? Atomic, volaltile? Does it aware of those kind of instructions?



================
Comment at: lib/Transforms/Vectorize/VPlanSLP.cpp:71
+
+  auto Res = BundleToCombined.insert({to_vector<4>(Operands), New});
+  assert(Res.second &&
----------------
use `try_emplace(to_vector<4>(Operands), New);` instead


================
Comment at: lib/Transforms/Vectorize/VPlanSLP.cpp:118
+
+  // For loads, check that there are instructions writing to memory in between
+  // them.
----------------
`are no instructions`?


https://reviews.llvm.org/D49491