[PATCH] D53710: [FileCheck] Warn if a prefix is only used in LABEL checks

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In https://reviews.llvm.org/D53710#1288598, @SjoerdMeijer wrote:

> Friendly ping.
>
> Does this look somewhat reasonable, and do what we want?


Hi Sjoerd.  Thanks for the changes you made.

The warning is still misleading when there are multiple prefixes.  See my earlier inline comment.  The easiest solution is probably to reword so that it never mentions a specific prefix.

I know you ran test/CodeGen/ARM, but did you try any other test suites?  This is only a warning, but changes to FileCheck have impact throughout LLVM, so it would nice to get a better preview of what others will see before pushing.


https://reviews.llvm.org/D53710