[PATCH] D54070: [WebAssembly] Update test cases after FixFunctionBitcasts

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 6 02:29:39 PST 2018


aheejin reclaimed this revision.
aheejin added a comment.

Hmm, come to think about it, maybe it's better to update the binaries in https://reviews.llvm.org/D54096 after all, because it adds a new section. (I'm not planning on updating these every time we change something on binaries) The reason is, for example, if I want to see the event section code is correctly printed in this test <https://github.com/llvm-mirror/llvm/blob/master/test/tools/llvm-readobj/sections.test>, I have to update binaries. And if I update binaries in https://reviews.llvm.org/D54096, this FixFunctionBitCasts changes will be all included in that CL, which I don't want.


Repository:
  rL LLVM

https://reviews.llvm.org/D54070





More information about the llvm-commits mailing list