[PATCH] D54122: [LLD] Fix precompiled headers build break on Linux

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added inline comments.


================
Comment at: COFF/SymbolTable.cpp:246
+    // A proper message will be emitted instead in PDBLinker::aquirePrecompObj
+    if (Name.contains("_PchSym_"))
+      continue;
----------------
@neerajksingh: Out of curiosity, could you please explain how _PchSym_ symbols are mangled? If I don't add this check, I get:
```
lld-link: error: <root>: undefined symbol: __@@_PchSym_ at 00@UhemUoowUgvhgUxluuUkivxlnkUkivxlnkOlyq at 4B2008FD98C1DD4
```
I find this confusing for users, I've consequently removed pch symbols, in order to emit a better message a bit later on.



Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54122