[PATCH] D54070: [WebAssembly] Update test cases after main wrapper generation

Mon Nov 5 14:14:23 PST 2018

aheejin added a comment.

In https://reviews.llvm.org/D54070#1287492, @sbc100 wrote:

> Hmm.. just to be clear, these tests are not failing on HEAD are they?

Before `test/Object/Inputs/WASM/string-outside-section.wasm` failed after I added the event section, but maybe it is because I reassigned section number incorrectly.

> Why not just leave them as is?

Yes I'm gonna leave them as is for now.

> Also, I've had some fallout from the change to enable the `main` wrappers by default so I think we should perhaps revert it.  Specifically the `test_mainenv` test in emscripten is failing because it expects envp to be set to null, not some undefined value (which happens to be non-null right now).

I rebased this CL on top of https://reviews.llvm.org/D54117. We apparently still have something to update because of FixFunctionBitCasts on `SomeOtherFunction`.

Repository:
  rL LLVM

https://reviews.llvm.org/D54070