[PATCH] D54119: [X86] Avoid creating a critical edge during cmov expansion

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 5 12:02:54 PST 2018


craig.topper added inline comments.


================
Comment at: test/CodeGen/X86/2011-12-26-extractelement-duplicate-load.ll:13
 ; CHECK:       # %bb.0:
-; CHECK-NEXT:    movaps (%rdi), %xmm0
-; CHECK-NEXT:    extractps $2, %xmm0, %eax
+; CHECK-NEXT:    movaps (%rdi), %xmm1
+; CHECK-NEXT:    extractps $2, %xmm1, %eax
----------------
This looks worse. We gained an instruction. There are similar instances of this in other tests.


https://reviews.llvm.org/D54119





More information about the llvm-commits mailing list