[PATCH] D53596: [ThinLTO] Fix a crash in lazy loading of Metadata

[Steven Wu via Phabricator via llvm-commits]

steven_wu accepted this revision.
steven_wu added a comment.
This revision is now accepted and ready to land.

Oh, I see. This is not really related to the debug information quality. It is a pure metadata lazy loading problem. LGTM.

The only suggestion I have (maybe can be done in a separate commit) is that none of the call site of getMDNodeFwdRefOrNull are expecting null as a valid output because they all check for nullptr and error out in some way. Maybe this function should really be:

  Error<MDNode*> getMDNodeFwdRef(unsigned);

And it can return a better error message.


Repository:
  rL LLVM

https://reviews.llvm.org/D53596