[PATCH] D53594: [GlobalISel] Introduce G_BUILD_VECTOR and G_CONCAT_VECTOR opcodes

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 5 09:47:03 PST 2018


aditya_nandakumar added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/MachineIRBuilder.cpp:554
+      getMRI()->getType(Res).getElementType().getSizeInBits())
+    return buildBuildVector(Res, Ops);
+  MachineInstrBuilder MIB = buildInstr(TargetOpcode::G_BUILD_VECTOR_TRUNC);
----------------
What's your take on just passing this to buildBuildVector vs asserting here?


Repository:
  rL LLVM

https://reviews.llvm.org/D53594





More information about the llvm-commits mailing list