[PATCH] D54070: [WebAssembly] Update test cases after main wrapper generation

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 5 09:33:06 PST 2018


sbc100 added a comment.

Hmm.. just to be clear, these tests are not failing on HEAD are they?

Why not just leave them as is?

Also, I've had some fallout from the change to enable the `main` wrappers by default so I think we should perhaps revert it.  Specifically the `test_mainenv` test in emscripten is failing because it expects envp to be set to null, not some undefined value (which happens to be non-null right now).


Repository:
  rL LLVM

https://reviews.llvm.org/D54070





More information about the llvm-commits mailing list