[PATCH] D54094: [ARM] Turn assert into condition in ARMCGP

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 5 03:04:14 PST 2018


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks like a straightforward fix/addition to me.



================
Comment at: test/CodeGen/ARM/CGP/arm-cgp-icmps.ll:324
+  %2 = and i8 %1, 1
+  %conv.i = mul nuw i8 %2, -124
+  %tobool = icmp eq i8 %conv.i, 0
----------------
nit: to test a mul with a negative number, we can probably have a more minimal example (we don't need a store, load, trunc, and).


https://reviews.llvm.org/D54094





More information about the llvm-commits mailing list