[PATCH] D50377: [LICM] Use ICFLoopSafetyInfo in LICM

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: lib/Transforms/Scalar/LICM.cpp:514
         ReciprocalDivisor->setFastMathFlags(I.getFastMathFlags());
+        SafetyInfo->insertInstructionTo(I.getParent());
         ReciprocalDivisor->insertBefore(&I);
----------------
apilipenko wrote:
> I think we can invalidate once. 
> 
> I know, in previous comments I was asking to move the complexity of the decision making whether the invalidation needed or not to the implementation of  the SafetyInfo, but calling invalidation two times in a row is simple enough to fix in the caller.
It is free anyways.


https://reviews.llvm.org/D50377