[PATCH] D53594: [GlobalISel] Introduce G_BUILD_VECTOR and G_CONCAT_VECTOR opcodes

[Volkan Keles via Phabricator via llvm-commits]

volkan added a comment.

In https://reviews.llvm.org/D53594#1280815, @aditya_nandakumar wrote:

> In https://reviews.llvm.org/D53594#1280811, @qcolombet wrote:
>
> > Thanks @aditya_nandakumar for the context.
> >
> > I understand where you're coming from.
> >
> > What I meant is that I would rather have one opcode of build_vector and one for build_vector with trunc. The rationale is that it makes it clear what you want to achieve and it makes for a stronger type verifier.
>
>
> +1 for having explicit opcodes for truncation.


+1

Either way we need to check if there is a truncate or not, having separate opcodes makes it easier to write combines/legality checks compared to dealing with types.


Repository:
  rL LLVM

https://reviews.llvm.org/D53594