[PATCH] D53425: Fix modules build of AVRAsmParser.cpp

[Dylan McKay via Phabricator via llvm-commits]

dylanmckay accepted this revision.
dylanmckay added a comment.
This revision is now accepted and ready to land.

Hey @arichardson, sorry for the delay, exam period!

This looks great. I remember building the LLVM tree recently, but I don't remember hitting this. I am unsure if I that was slightly before or slightly after you posted this patch on the 19th though.

The llvm-avr-linux <http://lab.llvm.org:8014/builders/llvm-avr-linux/builds/14266> buildbot running `clang` didn't seem to hit this either. Perhaps it's a GCC thing?

Regardless, `AVRAsmParser` is a private implementation detail of `createAVRAsmParser` and so moving it into an anonymous namespace makes sense.

Thanks for the patch @arichardson


Repository:
  rL LLVM

https://reviews.llvm.org/D53425