[PATCH] D52878: [test-suite] Add flags for stdthreadbug.cpp when building static

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 1 18:11:57 PDT 2018


MatzeB added a comment.

I'm not opposed to this change. But out of curiosity:

- Why don't you need to fix the other benchmarks that use `-pthread` as well?
- If your system requires extra flags to use libpthread, why don't you teach clang to do the right thing when it sees `-pthread`, I thought that is why we have `-pthread` in the first place instead of just using `-lpthread`.



================
Comment at: SingleSource/UnitTests/C++11/Makefile:15
+ifeq ($(ARCH),Mips)
+# TODO
+LDFLAGS += -Wl,--whole-archive -lpthread -Wl,--no-whole-archive
----------------
What is there `TODO` here?


https://reviews.llvm.org/D52878





More information about the llvm-commits mailing list