[PATCH] D50377: [LICM] Use ICFLoopSafetyInfo in LICM

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 1 18:04:21 PDT 2018


mkazantsev updated this revision to Diff 172290.
mkazantsev added a comment.
Herald added subscribers: nhaehnle, jvesely.

Updated test/CodeGen/AMDGPU/build-vector-insert-elt-infloop.ll

Without this patch, SaferyInfo falsely assumes that this loop is throwing and therefore prohibits promoter from elimination of the store. With smarter analysis, it is legal to eliminate the store, but the test doesn't expect that. Make store volatile to ensure that it doesn't get removed.


https://reviews.llvm.org/D50377

Files:
  include/llvm/Transforms/Utils/LoopUtils.h
  lib/Transforms/Scalar/LICM.cpp
  test/CodeGen/AMDGPU/build-vector-insert-elt-infloop.ll
  test/Transforms/LICM/guards.ll
  test/Transforms/LICM/hoist-mustexec.ll
  test/Transforms/LICM/hoist-nounwind.ll
  test/Transforms/LICM/preheader-safe.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50377.172290.patch
Type: text/x-patch
Size: 18403 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181102/c8ac0e83/attachment.bin>


More information about the llvm-commits mailing list