[PATCH] D53964: [WebAssembly] Expand inserts and extracts with variable indices

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 1 17:09:41 PDT 2018


tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1078
+  else
+    return SDValue();
+}
----------------
aheejin wrote:
> Maybe add comments on what this is supposed to do?
Done. Also added tests for `replace_lane`.


Repository:
  rL LLVM

https://reviews.llvm.org/D53964





More information about the llvm-commits mailing list