[PATCH] D53975: Start adding the supporting code to perform out-of-process allocator enumeration.

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

@kcc Please take another look at the patch. I have tried to address some of the issues you raised. I've removed one of the `ObjectView::IsLocal()` guards but the one around `EnsureSortedChunks()` remains.

There are various technical reasons why don't want to do this on the out-of-process path which I can explain if you really want. However could you explain something to me?

Why is `EnsureSortedChunks()` even called at all? I see nothing in the iteration code that would actually trigger a sort.
During the call to `ForEachChunk(...)` the allocator is also supposed to be locked so other threads won't be able to trigger a sort either. This suggests to me that the call to `EnsureSortedChunks()` is unnecessary, even on the in-process path. If we remove that then this `ObjectView::IsLocal()` guard issue just goes away.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D53975