[PATCH] D43142: Experimental pass to convert all floating point operations to the equivalent constrained intrinsics

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 1 16:28:51 PDT 2018


hfinkel added a comment.

In https://reviews.llvm.org/D43142#1284271, @cameron.mcinally wrote:

> In https://reviews.llvm.org/D43142#1284190, @kpn wrote:
>
> >
>


...

> It's unclear to me how LTO (or other cross file inlining) would work here. I haven't given it much though until now. My knee-jerk reaction is that we shouldn't be inlining from a FENV_ACCESS=OFF to FENV_ACCESS=ON location.

I'm pretty sure that we decided that we couldn't (because once you inline the regular FP ops, there's no way to restrict their movement relative to the constrained intrinsics at the IR level).


https://reviews.llvm.org/D43142





More information about the llvm-commits mailing list