[PATCH] D53945: [TextAPI] TBD Reader/Writer

Juergen Ributzka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 1 16:01:15 PDT 2018


ributzka added inline comments.


================
Comment at: llvm/include/llvm/TextAPI/ArchitectureSet.h:172
+
+} // end namespace llvm.
+
----------------
compnerd wrote:
> I wonder if we can get away with `llvm::BitVector` here.
A llvm::BitVector would require twice the storage size and dynamic memory allocation/deallocation. I tried to avoid that, since every symbol has an ArchitectureSet associated with it.


https://reviews.llvm.org/D53945





More information about the llvm-commits mailing list