[PATCH] D53996: [COFF, ARM64] Implement Intrinsic.sponentry for AArch64

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 1 14:27:30 PDT 2018


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with a minor tweak.



================
Comment at: test/CodeGen/AArch64/sponentry.ll:4
+; RUN: llc -mtriple=aarch64-windows-msvc %s -o - | FileCheck %s --check-prefix=NOFP
+; RUN: llc -mtriple=aarch64-windows-msvc -fast-isel %s -o - | FileCheck %s --check-prefix=NOFP
+
----------------
Please change the RUN lines to add "-verify-machineinstrs"; that'll allow catching mistakes faster in the future.


Repository:
  rL LLVM

https://reviews.llvm.org/D53996





More information about the llvm-commits mailing list