[llvm] r345887 - Enable -Wimplicit-fallthrough for clang as well as GCC

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 1 13:31:44 PDT 2018


Author: rnk
Date: Thu Nov  1 13:31:44 2018
New Revision: 345887

URL: http://llvm.org/viewvc/llvm-project?rev=345887&view=rev
Log:
Enable -Wimplicit-fallthrough for clang as well as GCC

All instances of this warning should already be fixed across all LLVM
subprojects, at least on Linux.

Modified:
    llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=345887&r1=345886&r2=345887&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Thu Nov  1 13:31:44 2018
@@ -580,6 +580,7 @@ if (LLVM_ENABLE_WARNINGS AND (LLVM_COMPI
     append("-Wno-long-long" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
   endif()
 
+  add_flag_if_supported("-Wimplicit-fallthrough" IMPLICIT_FALLTHROUGH_FLAG)
   add_flag_if_supported("-Wcovered-switch-default" COVERED_SWITCH_DEFAULT_FLAG)
   append_if(USE_NO_UNINITIALIZED "-Wno-uninitialized" CMAKE_CXX_FLAGS)
   append_if(USE_NO_MAYBE_UNINITIALIZED "-Wno-maybe-uninitialized" CMAKE_CXX_FLAGS)




More information about the llvm-commits mailing list