[PATCH] D53991: [Hexagon] Remove unintended fallthrough from MC duplex code

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 1 13:01:54 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL345883: [Hexagon] Remove unintended fallthrough from MC duplex code (authored by rnk, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D53991?vs=172204&id=172213#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D53991

Files:
  llvm/trunk/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp


Index: llvm/trunk/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp
===================================================================
--- llvm/trunk/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp
+++ llvm/trunk/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp
@@ -127,7 +127,7 @@
     case HexagonII::HSIG_A:
       return 0x4;
     }
-    LLVM_FALLTHROUGH; // FIXME: Intentional?
+    break;
   case HexagonII::HSIG_L2:
     switch (Gb) {
     default:
@@ -139,7 +139,7 @@
     case HexagonII::HSIG_A:
       return 0x5;
     }
-    LLVM_FALLTHROUGH; // FIXME: Intentional?
+    break;
   case HexagonII::HSIG_S1:
     switch (Gb) {
     default:
@@ -153,7 +153,7 @@
     case HexagonII::HSIG_A:
       return 0x6;
     }
-    LLVM_FALLTHROUGH; // FIXME: Intentional?
+    break;
   case HexagonII::HSIG_S2:
     switch (Gb) {
     default:
@@ -169,15 +169,15 @@
     case HexagonII::HSIG_A:
       return 0x7;
     }
-    LLVM_FALLTHROUGH; // FIXME: Intentional?
+    break;
   case HexagonII::HSIG_A:
     switch (Gb) {
     default:
       break;
     case HexagonII::HSIG_A:
       return 0x3;
     }
-    LLVM_FALLTHROUGH; // FIXME: Intentional?
+    break;
   case HexagonII::HSIG_Compound:
     switch (Gb) {
     case HexagonII::HSIG_Compound:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53991.172213.patch
Type: text/x-patch
Size: 1277 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181101/c2180ce6/attachment.bin>


More information about the llvm-commits mailing list