[PATCH] D53950: Enable -Wimplicit-fallthrough for clang as well as GCC

[Justin Bogner via Phabricator via llvm-commits]

bogner accepted this revision.
bogner added a comment.
This revision is now accepted and ready to land.

lgtm as long as there's general consent to the idea in the llvm-dev thread.



================
Comment at: clang-tools-extra/clang-tidy/google/AvoidCStyleCastsCheck.cpp:190
     }
-  // FALLTHROUGH
+    LLVM_FALLTHROUGH;  // FALLTHROUGH
   case clang::CK_IntegralCast:
----------------
rnk wrote:
> bogner wrote:
> > Having both LLVM_FALLTHROUGH and the comment is redundant.
> It is, but I made an effort to preserve comments like this everywhere, since I thought it might go down easier for more folks. It's not hard to remove them, of course.
I'd prefer them removed, unless someone really wants them for some reason.


https://reviews.llvm.org/D53950