[PATCH] D53976: [llvm-mca] Add extra counters for move elimination in view RegisterFileStatistics.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 1 10:20:13 PDT 2018


mattd accepted this revision.
mattd added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: tools/llvm-mca/Views/RegisterFileStatistics.cpp:25
+  RegisterFileUsage RFUEmpty = {0, 0, 0};
+  MoveEliminationInfo MEIEmpty = {0, 0, 0, 0, 0};
   if (!SM.hasExtraProcessorInfo()) {
----------------
You should be able to value initialize this RFUEmpty = {0}; MEIEmpty = {0};


================
Comment at: tools/llvm-mca/lib/HardwareUnits/RegisterFile.cpp:404
 
+void RegisterFile::addRegisterRead(ReadState &RS,
+                                   SmallVectorImpl<WriteRef> &DependentWrites) {
----------------
I think this routine can be marked const.


https://reviews.llvm.org/D53976





More information about the llvm-commits mailing list