[llvm] r345675 - DWARFVerifier: make the verifier more comprehensive for objects

[Adrian Prantl via llvm-commits]

Can you add a testcase for this?

-- adrian

> On Oct 30, 2018, at 4:45 PM, Saleem Abdulrasool via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: compnerd
> Date: Tue Oct 30 16:45:27 2018
> New Revision: 345675
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=345675&view=rev
> Log:
> DWARFVerifier: make the verifier more comprehensive for objects
> 
> Make the code do what was mentioned in the comment: only skip the CU types.
> This enables the lexical blocks to be verified as well.
> 
> Modified:
>    llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp
> 
> Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp?rev=345675&r1=345674&r2=345675&view=diff
> ==============================================================================
> --- llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp (original)
> +++ llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp Tue Oct 30 16:45:27 2018
> @@ -414,7 +414,7 @@ unsigned DWARFVerifier::verifyDieRanges(
>   // For now, simply elide the range verification for the CU DIEs if we are
>   // processing an object file.
> 
> -  if (!IsObjectFile || IsMachOObject || Die.getTag() == DW_TAG_subprogram) {
> +  if (!IsObjectFile || IsMachOObject || Die.getTag() != DW_TAG_compile_unit) {
>     for (auto Range : Ranges) {
>       if (!Range.valid()) {
>         ++NumErrors;
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits