[PATCH] D53918: Compile and test i128 math builtins for Win64

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: compiler-rt/lib/builtins/int_types.h:68-74
+/* MSVC doesn't have a working 128bit integer type. Users should really compile
+ * compiler-rt with clang, but if they happen to be doing a standalone build for
+ * asan or something else, disable the 128 bit parts so things sort of work.
+ */
+#if defined(_MSC_VER) && !defined(__clang__)
+#undef CRT_HAS_128BIT
+#endif
----------------
I went to test this with a variety of compilers before submitting, but basically, this part here is problematic in MSVC builds. In those builds, the builtins are built with the host compiler (cl.exe), but the tests are built with clang. So, the tests think i128 math is supported, but they all produce undefined symbol errors because the helper functions have been compiled out.

This needs more thought.


https://reviews.llvm.org/D53918