[PATCH] D53782: [llvm-objcopy] Don't apply --localize flags to common symbols

Jake Ehrlich via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 31 10:50:09 PDT 2018


Let's not break compaitableity then and just check the index. The fewer
cases this happens in the better IMO. I guess basically what you had at the
start was actually the best.

On Wed, Oct 31, 2018, 9:23 AM James Henderson via Phabricator <
reviews at reviews.llvm.org> wrote:

> jhenderson accepted this revision.
> jhenderson added a comment.
> This revision is now accepted and ready to land.
>
> LGTM.
>
> I haven't even been able to get the assembler to emit a STT_COMMON symbol.
> What does the assembly and command-line look like?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D53782
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181031/7e3f8f5c/attachment.html>


More information about the llvm-commits mailing list