[PATCH] D53815: [TableGen] Better error checking for TIED_TO constraints.

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham added inline comments.


================
Comment at: utils/TableGen/CodeGenInstruction.cpp:262-269
+  if (SrcOp.first >= Ops.NumDefs)
+    PrintFatalError(
+      Rec->getLoc(), "Input operands '" + SrcOpName + "' and '" + DestOpName +
+      "' of '" + Rec->getName() + "' cannot be tied!");
+  if (DestOp.first < Ops.NumDefs)
+    PrintFatalError(
+      Rec->getLoc(), "Output operands '" + SrcOpName + "' and '" + DestOpName +
----------------
nhaehnle wrote:
> The naming of SrcOp and DestOp should be reversed. It's quite confusing as-is ;)
Yes, I see what you mean – now that we're enforcing that one of the operands is written and the other is read, it makes particularly little sense to call them 'source' and 'destination' in that order :-) I'll fix it.


Repository:
  rL LLVM

https://reviews.llvm.org/D53815