[PATCH] D53804: [llvm-objdump] add support for '--reloc' as an alias of -r (PR39407)

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 31 02:59:15 PDT 2018


jhenderson added a comment.

In https://reviews.llvm.org/D53804#1281883, @Higuoxing wrote:

> Is this version ok? Shall I update other options flag in another patch? Thanks a lot for your advice


What you did is fine for now. I do think we should consider working on the command-line options a bit more in llvm-objdump. There are a few issues that I know of already, including https://bugs.llvm.org/show_bug.cgi?id=37895 (which covers the missing single-letter alias options in the help text) and https://bugs.llvm.org/show_bug.cgi?id=31679 (which points out that single-letter options don't combine properly (e.g. you can't do -fsr). The command-line options are also not GNU-compatible in some instances, in that they do different things. I'm going to raise a thread on the mailing list about this, if I get a chance, as to fix it, we'd have to change the meaning of some of the current options.


Repository:
  rL LLVM

https://reviews.llvm.org/D53804





More information about the llvm-commits mailing list