[PATCH] D53920: [XRay] Add CPU ID in Custom Event FDR Records

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 30 23:36:34 PDT 2018


dberris created this revision.
dberris added reviewers: mboerger, eizan.
Herald added subscribers: mgrang, hiraditya.

This change cuts across compiler-rt and llvm, to increment the FDR log
version number to 4, and include the CPU ID in the custom event records.

This is a step towards allowing us to change the `llvm::xray::Trace`
object to start representing both custom and typed events in the stream
of records. Follow-on changes will allow us to change the kinds of
records we're presenting in the stream of traces, to incorporate the
data in custom/typed events.

A follow-on change will handle the typed event case, where it may not
fit within the 15-byte buffer for metadata records.

This work is part of the larger effort to enable writing analysis and
processing tools using a common in-memory representation of the events
found in traces. The work will focus on porting existing tools in LLVM
to use the common representation and informing the design of a
library/framework for expressing trace event analysis as C++ programs.


https://reviews.llvm.org/D53920

Files:
  compiler-rt/lib/xray/xray_fdr_controller.h
  compiler-rt/lib/xray/xray_fdr_log_writer.h
  compiler-rt/lib/xray/xray_fdr_logging.cc
  llvm/include/llvm/XRay/FDRRecords.h
  llvm/lib/XRay/FDRTraceWriter.cpp
  llvm/lib/XRay/FileHeaderReader.cpp
  llvm/lib/XRay/RecordInitializer.cpp
  llvm/lib/XRay/RecordPrinter.cpp
  llvm/lib/XRay/Trace.cpp
  llvm/unittests/XRay/FDRProducerConsumerTest.cpp
  llvm/unittests/XRay/FDRRecordPrinterTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53920.171865.patch
Type: text/x-patch
Size: 9036 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181031/c19db256/attachment.bin>


More information about the llvm-commits mailing list